gaborkaszab commented on PR #6074: URL: https://github.com/apache/iceberg/pull/6074#issuecomment-1371076213
> This looks good to me other than a couple of small things to fix: > > * revapi suppressions are reordered, which is going to introduce churn > * It isn't clear why this wouldn't work with a create transaction Thanks for the reviews so far, @rdblue! - revapi part should be ok now - I removed that Precondition that didn't allow to use SnapshotManager with a createTransaction. However, I think that keeping that Precondition would make sense as with a createTransction we wouldn't have snapshot IDs nor branch names so we wouldn't be able to do much on that SnapshotManager anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
