stevenzwu commented on code in PR #6222:
URL: https://github.com/apache/iceberg/pull/6222#discussion_r1043887176
##########
core/src/main/java/org/apache/iceberg/BaseFilesTable.java:
##########
@@ -200,13 +202,14 @@ private CloseableIterable<? extends ContentFile<?>>
files(Schema fileProjection)
}
}
- private StructLike withReadableMetrics(ContentFile<?> file) {
- int expectedSize = projection.columns().size();
+ private StructLike withReadableMetrics(ContentFile<?> file, int
metricsPosition) {
+ int columnSize = projection.columns().size();
Review Comment:
nit: `fieldCount` or `columnCount` is probably more clear. `columnSize` can
be read as the byte size of one particular column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
