stevenzwu commented on code in PR #6313:
URL: https://github.com/apache/iceberg/pull/6313#discussion_r1040423889
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -107,6 +107,30 @@ public static MetricsConfig forPositionDelete(Table table)
{
return new MetricsConfig(columnModes.build(), defaultMode);
}
+ /**
+ * Creates a metrics config for a position delete file.
+ *
+ * @param props table configuration
+ */
+ public static MetricsConfig forPositionDelete(Map<String, String> props) {
Review Comment:
@chenjunjiedada hmm. I think we should revert the last commit. if we are
going to pass in the `Table` object, it should be non-null. Then we can
consistently use `forTable` everywhere.
I would also be open with the `forProperties` approach, as you were saying
that schema and sort order are for data rows/files. I had some reservations
because `MetricConfig` deprecated `forProperties` for data rows/files. It is a
little weird to introduce it back for position delete. Flink can use
`forPositionDelete(Table table)` API by passing a valid `SerializableTable`
object to `FlinkAppenderFactory`. With `Table` object, we can remove the
`Schema` and `PartitionSpec` from the current `FlinkAppenderFactory` constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
