stevenzwu commented on code in PR #6313:
URL: https://github.com/apache/iceberg/pull/6313#discussion_r1038640162
##########
core/src/main/java/org/apache/iceberg/MetricsConfig.java:
##########
@@ -107,6 +107,30 @@ public static MetricsConfig forPositionDelete(Table table)
{
return new MetricsConfig(columnModes.build(), defaultMode);
}
+ /**
+ * Creates a metrics config for a position delete file.
+ *
+ * @param props table configuration
+ */
+ public static MetricsConfig forPositionDelete(Map<String, String> props) {
Review Comment:
@chenjunjiedada what do you think of using the existing API? I know it would
require changes in `FlinkAppenderFactory` to pass in the `Table` object.
```
public static MetricsConfig forPositionDelete(Table table) {
```
The benefit is that position delete file will get the consistent behavior as
data file. unless we are saying position delete has its own schema, shared code
path doesn't really make sense.
```
private static MetricsConfig from(Map<String, String> props, Schema
schema, SortOrder order) {
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
