rdblue commented on code in PR #6141:
URL: https://github.com/apache/iceberg/pull/6141#discussion_r1022106845


##########
python/tests/expressions/test_literals.py:
##########
@@ -448,35 +466,61 @@ def test_fixed_to_binary():
 
 def test_fixed_to_smaller_fixed_none():
     lit = literal(bytearray([0x00, 0x01, 0x02])).to(FixedType(3))
-    assert lit.to(FixedType(2)) is None
+    with pytest.raises(ValueError) as e:
+        lit.to(lit.to(FixedType(2)))
+    assert "Could not convert b'\\x00\\x01\\x02' into a fixed[2]" in 
str(e.value)

Review Comment:
   Different length?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to