Fokko commented on code in PR #6141: URL: https://github.com/apache/iceberg/pull/6141#discussion_r1019433513
########## python/pyiceberg/expressions/literals.py: ########## @@ -125,81 +127,73 @@ def literal(value) -> Literal: @literal.register(bool) -def _(value: bool) -> Literal[bool]: +def _(value: bool) -> BooleanLiteral: Review Comment: `BooleanLiteral` extends from `Literal[bool]`, so we get the `Literal[bool]` for free. I think it is nice to be specific here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
