rdblue commented on code in PR #6145: URL: https://github.com/apache/iceberg/pull/6145#discussion_r1018424138
########## python/pyiceberg/table/__init__.py: ########## @@ -32,13 +33,19 @@ from pyiceberg.table.snapshots import Snapshot, SnapshotLogEntry from pyiceberg.table.sorting import SortOrder from pyiceberg.typedef import EMPTY_DICT, Identifier, Properties -from pyiceberg.utils.iceberg_base_model import IcebergBaseModel -class Table(IcebergBaseModel): +class Table: identifier: Identifier = Field() - metadata_location: str = Field() metadata: TableMetadata = Field() + metadata_location: str = Field() Review Comment: Should this also remove `Field()`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org