rdblue commented on code in PR #6145: URL: https://github.com/apache/iceberg/pull/6145#discussion_r1017249517
########## python/pyiceberg/table/__init__.py: ########## @@ -90,3 +119,53 @@ def snapshot_by_name(self, name: str) -> Optional[Snapshot]: def history(self) -> List[SnapshotLogEntry]: """Get the snapshot history of this table.""" return self.metadata.snapshot_log + + +class TableScan: + table: Table + row_filter: BooleanExpression + partition_filter: BooleanExpression + selected_fields: Tuple[str] + case_sensitive: bool + snapshot_id: Optional[int] + options: Properties + + def __init__( + self, + table: Table, + row_filter: Optional[BooleanExpression], + partition_filter: Optional[BooleanExpression], + selected_fields: Tuple[str] = ("*",), + case_sensitive: bool = True, + snapshot_id: Optional[int] = None, + options: Properties = EMPTY_DICT, + ): + self.table = table + self.row_filter = row_filter or AlwaysTrue() + self.partition_filter = partition_filter or AlwaysTrue() Review Comment: Looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org