stevenzwu commented on code in PR #6111: URL: https://github.com/apache/iceberg/pull/6111#discussion_r1017328011
########## flink/v1.14/flink/src/main/java/org/apache/iceberg/flink/FlinkCatalogFactory.java: ########## @@ -145,8 +145,27 @@ protected Catalog createCatalog( baseNamespace = Namespace.of(properties.get(BASE_NAMESPACE).split("\\.")); } - boolean cacheEnabled = Boolean.parseBoolean(properties.getOrDefault(CACHE_ENABLED, "true")); - return new FlinkCatalog(name, defaultDatabase, baseNamespace, catalogLoader, cacheEnabled); + boolean cacheEnabled = CatalogProperties.CACHE_ENABLED_DEFAULT; + if (properties.containsKey(CatalogProperties.CACHE_ENABLED)) { + cacheEnabled = Boolean.parseBoolean(properties.get(CatalogProperties.CACHE_ENABLED)); + } + + long cacheExpirationIntervalMs = + PropertyUtil.propertyAsLong( + properties, + CatalogProperties.CACHE_EXPIRATION_INTERVAL_MS, + CatalogProperties.CACHE_EXPIRATION_INTERVAL_MS_DEFAULT); + if (cacheExpirationIntervalMs == 0) { Review Comment: I understood the overlap btw the boolean flag and the expire value at 0. But dropping `cacheEnabled ` would be a breaking change, which we should try to avoid -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org