aokolnychyi commented on code in PR #2276: URL: https://github.com/apache/iceberg/pull/2276#discussion_r1017019275
########## api/src/main/java/org/apache/iceberg/util/StructProjection.java: ########## @@ -90,6 +91,19 @@ public static StructProjection createAllowMissing( private final StructProjection[] nestedProjections; private StructLike struct; + private StructProjection(StructProjection other) { + this.type = other.type; + this.positionMap = Review Comment: I think that should be safe since we have a projection per spec. It wouldn't be safe if we reused one projection for multiple specs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org