aokolnychyi commented on code in PR #2276:
URL: https://github.com/apache/iceberg/pull/2276#discussion_r1015562517
##########
core/src/main/java/org/apache/iceberg/util/TableScanUtil.java:
##########
@@ -71,6 +78,57 @@ public static CloseableIterable<FileScanTask> splitFiles(
return CloseableIterable.combine(splitTasks, tasks);
}
+ public static <T extends FileScanTask> Iterable<CombinedScanTask> planTasks(
Review Comment:
@rdblue, the problem is that we actually need to know the spec. That way, we
can build a projection to select required partition fields for combining. I
thought `PartitionScanTask` would be implemented in non-combined tasks like
`FileScanTask`. Such tasks belong to one partition only.
We may need a way to expose a combine key in `ScanTaskGroup` but I'd say
that's different.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
