[GitHub] [iceberg] danielcweeks commented on a diff in pull request #6045: [iceberg-hive-metastore] Support setting individual and group ownership for Namespace

[GitBox]

danielcweeks commented on code in PR #6045:
URL: https://github.com/apache/iceberg/pull/6045#discussion_r1010730010


##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -361,4 +361,6 @@ private TableProperties() {}
   public static final boolean UPSERT_ENABLED_DEFAULT = false;
 
   public static final String HMS_TABLE_OWNER = "hms_table_owner";
+  public static final String HMS_DB_OWNER = "hms_db_owner";

Review Comment:
   I feel like we probably want to update these properties to be consistent 
with the rest of the table properties convention (i.e. 
`hive.metastore.table.owner`, `hive.metastore.database.owner`, 
`hive.metastore.database.owner-type`).  Is there a specific reason for the 
proposed property names?  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org