haizhou-zhao commented on code in PR #6045:
URL: https://github.com/apache/iceberg/pull/6045#discussion_r1010591871
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -257,21 +259,42 @@ public void testReplaceTxnBuilder() throws Exception {
public void testCreateTableWithOwner() throws Exception {
Schema schema = getTestSchema();
PartitionSpec spec = PartitionSpec.builderFor(schema).bucket("data",
16).build();
- TableIdentifier tableIdent = TableIdentifier.of(DB_NAME, "tbl");
- String location = temp.newFolder("tbl").toString();
String owner = "some_owner";
- ImmutableMap<String, String> properties =
- ImmutableMap.of(TableProperties.HMS_TABLE_OWNER, owner);
-
+ Map<String, String> prop =
ImmutableMap.of(TableProperties.HMS_TABLE_OWNER, owner);
+
+ createTableAndVerifyOwnership(DB_NAME, "tbl", schema, spec, prop, owner);
+
+ prop = ImmutableMap.of();
+
+ // a table without an owner explicitly specified should have a default
owner
+ createTableAndVerifyOwnership(
+ DB_NAME,
+ "no_explicit_owner_specified_tbl",
+ schema,
+ spec,
+ prop,
Review Comment:
This change is no longer needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
