chenjunjiedada commented on code in PR #6012: URL: https://github.com/apache/iceberg/pull/6012#discussion_r1000069252
########## api/src/main/java/org/apache/iceberg/ChangelogOperation.java: ########## @@ -21,5 +21,7 @@ /** An enum representing possible operations in a changelog. */ public enum ChangelogOperation { INSERT, - DELETE + DELETE, + UPDATE_PREIMAGE, + UPDATE_POSTIMAGE Review Comment: I think we can add some doc for the detail, shorter string brings better performance in case we store row kind info into files and performs comparing row by row later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org