flyrain commented on code in PR #6012: URL: https://github.com/apache/iceberg/pull/6012#discussion_r998766373
########## api/src/main/java/org/apache/iceberg/ChangelogOperation.java: ########## @@ -21,5 +21,7 @@ /** An enum representing possible operations in a changelog. */ public enum ChangelogOperation { INSERT, - DELETE + DELETE, + UPDATE_PREIMAGE, + UPDATE_POSTIMAGE Review Comment: I also like the idea of a short version of CDC record Type like (I,D, -U, +U). What do you think? 1. Insert(I), indicating an inserted row 2. Delete(D), indicating a deleted row 3. Pre-update(-U), indicating the original value of an updated row 4. Post-update(+U), indicating the new value of an updated row -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org