rdblue commented on code in PR #18816:
URL: https://github.com/apache/iceberg/pull/18816#discussion_r4621372505
##########
core/src/main/java/org/apache/iceberg/V4ManifestReader.java:
##########
@@ -480,7 +604,44 @@ V4ManifestReader build() {
partitionProjections(),
requestedStatsFieldIds,
isUncommitted,
- scanMetrics);
+ scanMetrics,
+ changes,
+ deletedReference,
+ changes ? resolveChangeSnapshotId(tracking) : 0L,
Review Comment:
Style: It is better to pass null than to pass incorrect values when they
won't be used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]