rdblue commented on code in PR #18816:
URL: https://github.com/apache/iceberg/pull/18816#discussion_r4621119429


##########
core/src/main/java/org/apache/iceberg/TrackingStruct.java:
##########
@@ -180,6 +180,29 @@ boolean assignFirstRowId(Long nextRowId) {
     return false;
   }
 
+  /**
+   * Mark this entry as deleted in the given snapshot.
+   *
+   * @param newSnapshotId the snapshot ID in which the entry was deleted
+   */
+  void markDeleted(long newSnapshotId) {
+    mark(EntryStatus.DELETED, newSnapshotId);
+  }
+
+  /**
+   * Mark this entry as replaced in the given snapshot.
+   *
+   * @param newSnapshotId the snapshot ID in which the entry was replaced
+   */
+  void markReplaced(long newSnapshotId) {
+    mark(EntryStatus.REPLACED, newSnapshotId);
+  }
+
+  private void mark(EntryStatus newStatus, long newSnapshotId) {

Review Comment:
   I don't think this is worth a separate method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to