Fokko commented on code in PR #4397:
URL: https://github.com/apache/iceberg-python/pull/4397#discussion_r4604433140


##########
pyiceberg/table/update/partition_statistics.py:
##########
@@ -0,0 +1,75 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+from typing import TYPE_CHECKING
+
+from pyiceberg.table.statistics import PartitionStatisticsFile
+from pyiceberg.table.update import (
+    RemovePartitionStatisticsUpdate,
+    SetPartitionStatisticsUpdate,
+    TableUpdate,
+    UpdatesAndRequirements,
+    UpdateTableMetadata,
+)
+
+if TYPE_CHECKING:
+    from pyiceberg.table import Transaction
+
+
+class 
UpdatePartitionStatistics(UpdateTableMetadata["UpdatePartitionStatistics"]):
+    """
+    Run partition statistics management operations using APIs.
+
+    APIs include set_partition_statistics and remove_partition_statistics 
operations.
+
+    Use table.update_partition_statistics().<operation>().commit() to run a 
specific operation.
+    Use 
table.update_partition_statistics().<operation-one>().<operation-two>().commit()
 to run multiple operations.
+
+    Pending changes are applied on commit. Sets are applied before removals, 
so a removal wins over a set
+    for the same snapshot, regardless of the order of the calls.
+
+    We can also use context managers to make more changes. For example:
+
+    with table.update_partition_statistics() as update:
+        
update.set_partition_statistics(partition_statistics_file=partition_statistics_file)
+        update.remove_partition_statistics(snapshot_id=2)
+    """
+
+    _sets: dict[int, SetPartitionStatisticsUpdate]
+    _removals: dict[int, RemovePartitionStatisticsUpdate]
+
+    def __init__(self, transaction: "Transaction") -> None:
+        super().__init__(transaction)
+        self._sets = {}
+        self._removals = {}
+
+    def set_partition_statistics(self, partition_statistics_file: 
PartitionStatisticsFile | None) -> "UpdatePartitionStatistics":

Review Comment:
   Let's avoid passing in the `PartitionStatisticsFile` itself. Let's pass in 
the parameters to construct a `PartitionStatisticsFile` instead, so the object 
can evolve separately from the API here.
   
   Also, let's make sure to add docstrings here and at 
remove_partition_statistics, since it is a public API



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to