rahulsmahadev commented on PR #4397:
URL: https://github.com/apache/iceberg-python/pull/4397#issuecomment-6957462373

   Good point. Java splits the two: 
`PartitionStatsHandler.computeAndWriteStatsFile` computes the stats 
(incrementally from the previous stats file) and writes the file, and 
`ComputePartitionStatsSparkAction` then registers it with 
`table.updatePartitionStatistics().setPartitionStatistics(file).commit()`. This 
PR adds that registration step, so a compute step can build on it. I'm happy to 
follow up with a PR that computes and writes the partition statistics file in 
PyIceberg and registers it through this API, or to add the computation here if 
you'd rather review them together. Which do you prefer?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to