dramaticlly commented on code in PR #18935:
URL: https://github.com/apache/iceberg/pull/18935#discussion_r4603023271


##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -1158,6 +1158,12 @@ private Map<Integer, NestedField> lazyFieldsById() {
   public static final class FileType extends NestedType {
     public static final String NAME = "file";
     public static final int NUM_NESTED_FIELDS = 6;
+    public static final int URI_ID_OFFSET = 1;

Review Comment:
   Since we provided such language in spec on which sub field to collect 
metrics for, and types is in API and shall not bother itself with underlying 
metrics, I feel the metrics config might be the best place based on how code 
was organized. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to