RussellSpitzer commented on code in PR #18935:
URL: https://github.com/apache/iceberg/pull/18935#discussion_r4602891107


##########
api/src/main/java/org/apache/iceberg/types/Types.java:
##########
@@ -1158,6 +1158,12 @@ private Map<Integer, NestedField> lazyFieldsById() {
   public static final class FileType extends NestedType {
     public static final String NAME = "file";
     public static final int NUM_NESTED_FIELDS = 6;
+    public static final int URI_ID_OFFSET = 1;

Review Comment:
   We would have to make the field names public then instead, or just redefine 
them in Metrics Conf. So we can either expose the names or the ids. So then I 
would have on metrics config
   
   DEFAULT_FILE_INFERRED = {URI, ...}
   
   Or we could just give up on the magic strings and make it
   
   DEFAULT|_FILE_INFERRED = {"uri", ...}



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to