zeroshade commented on issue #2062: URL: https://github.com/apache/iceberg-go/issues/2062#issuecomment-6954548038
> table/substrait exports three helpers that return substrait-go v8 and arrow compute/exprs types, which makes the v9 bump (https://github.com/apache/iceberg-go/pull/2259) a breaking change once we tag. Only table imports the package. OK to move it to table/internal/substrait for v1? Exporting it again later is additive. arrow-go hasn't bumped to v9 yet, so we can't bump substrait-go here yet. That said, i'm okay with moving our usage of substrait to `table/internal/substrait` for v1. We should avoid exporting it if possible. > blobfs.FileIO embeds *blob.Bucket, so 20 Bucket methods from gocloud.dev (still v0) are part of our API. Outside blobfs, our own code only relies on Close. OK to make it a named field with a Bucket() accessor? The embedding was intentional originally to have various methods get propagated for usage via interfaces. At this point I think our IO interfaces have deviated enough from `blob.Bucket` that you're right, though I think the better route would be to just not export `BlobFileIO` and instead only make it accessible via interfaces like we do for the rest of the structs in this file (`blobFileInfo`, `blobOpenFile`, etc.) Let's just unexport `BlobFileIO`, keep `blob.Bucket` embedded, and then just expose it via the various `IO` interfaces like we do for the other file systems. The only thing that explicitly references it outside of `io/gocloud/` is a check in `catalog/hadoop/` for `HadoopCatalogFS`, but we could instead just validate it against the interface instead of it being `(*gocloud.BlobFileIO)(nil)`. > `RewriteDataFiles` and the other actions that produce a commit stay on Table / Transaction for v1, as proposed on https://github.com/apache/iceberg-go/issues/2083. Any objection? No objections from me here. > The rest of section 1 (the Substrait engine inside table, the backend module split) has no owner and changes no exported Go API, so I'd move both after the tag. OK? As long as there's no exported API changes necessary to do it, i'm fine with it being after the tag. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
