laskoviymishka commented on issue #2062: URL: https://github.com/apache/iceberg-go/issues/2062#issuecomment-6901150517
Status refresh. I'll fold it into the body afterwards. **Left before the tag** 1. #2390 (SQL nested namespaces, `!`): approved and green, merging it. 2. Inspect move, #2083: PR 1 (#2582) is in, PR 2 and PR 3 are @Revanth14's. 3. Immutability (@Revanth14): constructors and most of the literal migration are in (#2431, #2484, #2496, #2568). The unexport PR goes last, under the freeze. 4. Context on `RemoveAllIO.RemoveAll` and `MkdirAllIO.MkdirAll` (breaking). 5. Isolated FileIO registries for the non-REST catalogs and `view.CreateView` (additive, can follow the tag). @iceberg-kitten welcome back :) 4 and 5 were in flight before. Are you planning to reopen them? 4 has to land before the tag, so if you'd rather not, just say so and I'll pick it up. **Three small breaking items nobody owns.** I'll take them, one PR each, unless someone objects: - `VisitBoundPredicateRef` is exported behind an `internal` token, so it has the same type-inference hole as the schema `Ref` accessors, and the immutability series doesn't remove it. I'll take it out of the public API and keep the zero-copy path for our evaluators. - `sql.NewCatalog` creates its tables on `context.Background()` and `hive.NewCatalog` connects to the metastore without a context. The REST, Hadoop and DynamoDB constructors already take one, so I'll add `ctx` to these two. - `table/substrait` exports three helpers that return substrait-go v8 types, which makes the v9 bump (#2259) a breaking change once we tag. Only `table` imports the package. @zeroshade, are you OK with moving it to `table/internal/substrait` for v1? Exporting it again later is additive. **Decisions to log** (@zeroshade) - `RewriteDataFiles` and the other actions that produce a commit stay on `Table` / `Transaction` for v1, as proposed on #2083. Any objection? - The rest of section 1 (the Substrait engine inside `table`, the backend module split) has no owner and changes no exported Go API, so I'd move both after the tag. OK? AI-assisted, reviewed by a human. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
