gaborkaszab commented on code in PR #17545:
URL: https://github.com/apache/iceberg/pull/17545#discussion_r4599268402


##########
api/src/main/java/org/apache/iceberg/encryption/EncryptingFileIO.java:
##########
@@ -68,11 +65,11 @@ public static EncryptingFileIO combine(FileIO io, 
EncryptionManager em) {
     this.em = em;
   }
 
-  public Map<String, InputFile> bulkDecrypt(Iterable<? extends ContentFile<?>> 
files) {
+  public Map<String, InputFile> bulkDecrypt(Iterable<? extends EncryptedFile> 
files) {

Review Comment:
   We are widening the parameter type, so revapi doesn't complain. I'm not 
entirely sure if this counts as breaking change. Internally, once 
https://github.com/apache/iceberg/pull/18486 is merged, the Spark usage is 
gone, and the only non-test usage will be from `InputFilesDecryptor` that is 
the end goal.
   
   For custom implementations: the constructor of `EncryptingFileIO` is package 
private, so custom implementations aren't feasible outside the package. I'd say 
this is safe then.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to