pvary commented on code in PR #17545:
URL: https://github.com/apache/iceberg/pull/17545#discussion_r4597906121


##########
api/src/main/java/org/apache/iceberg/io/FileIO.java:
##########
@@ -71,6 +72,11 @@ default InputFile newInputFile(ManifestFile manifest) {
     return newInputFile(manifest.path(), manifest.length());
   }
 
+  /**
+   * @deprecated since 1.13.0, will be removed in 2.0.0; use {@link
+   *     #newInputFile(FileWithEncryptedKey)} instead.
+   */
+  @Deprecated
   default InputFile newInputFile(ManifestListFile manifestList) {

Review Comment:
   For me it seems like a good compromise, to leave out `ManifestListFile` but 
standardize on the other files.
   What do you think @danielcweeks?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to