fredpower44 opened a new pull request, #3703:
URL: https://github.com/apache/iceberg-rust/pull/3703
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Part of apache/iceberg#18126. Stacked on #3688: only the last commit,
`feat(rest): expose catalog
labels on Table`, is new.
## What changes are included in this PR?
<!--
Provide a summary of the modifications in this PR. List the main changes
such as new features, bug fixes, refactoring, or any other updates.
-->
Adds `Table::labels()` and `TableBuilder::labels()`, and sets labels from
the `LoadTableResult` returned
by REST `load_table`, `create_table` and `register_table`. Because labels
live on `Table`, a reload
served from the ETag cache returns the cached labels. A table returned by
a commit has no labels, because
the commit response doesn't include them; Go and C++ behave the same way.
Happy to carry them over in
`Transaction::commit` instead if that's preferred.
## Are these changes tested?
<!--
Specify what test covers (unit test, integration test, etc.).
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes. REST catalog tests cover labels from load, create and register, and
`None` when the response has no
labels.
## AI Disclosure
<!--
https://iceberg.apache.org/contribute/#guidelines-for-ai-assisted-contributions
-->
Code, tests and this description were drafted with Claude Code (Claude Opus
5.5). I reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]