Anurag-S1ngh opened a new pull request, #4393: URL: https://github.com/apache/iceberg-python/pull/4393
## Summary Renaming a struct that contains an identifier field failed at commit with `Cannot find identifier field user.id`, because `UpdateSchema` kept identifier fields as dotted names and only rewrote an exact name match on rename. ## Changes - Track identifier fields by field ID from the starting schema, matching how the spec stores them. - Resolve names passed to `set_identifier_fields` to IDs where they exist, and keep resolving names that only exist after the update (such as newly added columns) against the resulting schema at commit. - Drop the rename-specific name rewrite, which is no longer needed. ## Testing - Added unit tests for renaming a struct with an identifier field, renaming an identifier field itself, renaming after `set_identifier_fields`, and deleting an identifier field. - `make test` passes (4696 passed, 5 skipped). Closes #4373 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
