laskoviymishka commented on code in PR #2389:
URL: https://github.com/apache/iceberg-go/pull/2389#discussion_r4577778066
##########
catalog/rest/external_conformance_test.go:
##########
@@ -71,9 +76,17 @@ func TestExternalRestCatalogConformance(t *testing.T) {
props["warehouse"] = warehouse
}
+ nestedNamespaces := false
+ if v := os.Getenv(externalNestedNamespacesEnv); v != "" {
Review Comment:
When `REST_CATALOG_NESTED_NAMESPACES` is unset, both nested tests drop out
of the run with no skip line, so if the env ever moves off the Polaris step in
`go-integration.yml` we'd lose that coverage without noticing. Could we log it
here when the flag is off?
```go
if !nestedNamespaces {
t.Logf("%s not set: skipping the nested namespace tests",
externalNestedNamespacesEnv)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]