badalprasadsingh commented on code in PR #2389:
URL: https://github.com/apache/iceberg-go/pull/2389#discussion_r4515589591
##########
catalog/rest/conformance_test.go:
##########
@@ -34,6 +34,9 @@ func TestRestCatalogConformance(t *testing.T) {
catalogtest.RunCatalogTests(t, catalogtest.Config{
SupportsNamespaceProperties: true,
SupportsRenameTable: true,
+ // SupportsNestedNamespaces stays off: the published fixture
(1.10.1)
+ // drops a namespace that still has children, which
apache/iceberg#16061
+ // fixed in 1.11.0, and no newer fixture image is published yet.
Review Comment:
nit (non-blocking): nothing tracks turning this flag on later, can you
please add a todo citing an issue, eg,
`TODO(#1880): set SupportsNestedNamespaces once a published fixture includes
apache/iceberg#16061?`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]