vivek-9941 commented on PR #18361: URL: https://github.com/apache/iceberg/pull/18361#issuecomment-6891882070
Thanks for running those three states — that's exactly the confirmation the tests needed. Dropped positionDeleteAndDVBuiltBeforePromotionCommittedAfter as suggested (commit d354ad99a). The three remaining tests cover the same ground without duplication: positionDeleteBuiltBeforePromotionCommittedAfter — v2, position delete deletionVectorBuiltBeforePromotionCommittedAfter — v3+, deletion vector equalityDeleteBuiltBeforePromotionCommittedAfter — v2+, equality delete Also fixed the extra indentation on the closing brace of the iceberg-gcp block in build.gradle, and synced with the latest upstream/main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
