vivek-9941 commented on PR #18361: URL: https://github.com/apache/iceberg/pull/18361#issuecomment-6623014942
You're absolutely right - and thank you for catching that! The previous tests committed delete files BEFORE updateSchema(), so ManifestWriter never saw an Integer value under a Long spec. They passed even without the normalization fix. Fixed in commit 0d68e310b by building delete files BEFORE promotion but committing them AFTER: New tests (all follow: build delete → commit data → promote → commit delete): ✅ positionDeleteBuiltBeforePromotionCommittedAfter (v2) - Position deletes ✅ deletionVectorBuiltBeforePromotionCommittedAfter (v3+) - Deletion vectors ✅ equalityDeleteBuiltBeforePromotionCommittedAfter (v2+) - Your suggested test ✅ positionDeleteAndDVBuiltBeforePromotionCommittedAfter (v2+) - Comprehensive coverage Validation: Tests now fail without ManifestWriter normalization (b9aa4ab9b) ❌ Tests pass with the fix ✅ Added CloseableIterable import as suggested All four tests properly validate that ManifestWriter normalizes Integer partition values when writing under a promoted Long spec. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
