gaborkaszab commented on code in PR #18884:
URL: https://github.com/apache/iceberg/pull/18884#discussion_r4560514759
##########
core/src/main/java/org/apache/iceberg/FilePlanner.java:
##########
@@ -163,6 +168,14 @@ CloseableIterable<FileScanTask> planFiles() {
return CloseableIterable.transform(dataFiles, this::createTask);
}
+ private static void rejectColumnFiles(TrackedFile entry) {
Review Comment:
Seems more natural to reject such files in the adapter right away. However,
rejecting it here gives us the freedom to do development on the reader while we
still reject column files in the planner. No strong opinion, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]