gaborkaszab commented on code in PR #18884:
URL: https://github.com/apache/iceberg/pull/18884#discussion_r4561392056


##########
core/src/main/java/org/apache/iceberg/SnapshotScan.java:
##########
@@ -185,6 +186,37 @@ public Snapshot snapshot() {
     return snapshotId() != null ? table().snapshot(snapshotId()) : 
table().currentSnapshot();
   }
 
+  /** Plans file scan tasks for a snapshot that references a v4 root manifest. 
*/

Review Comment:
   Just double-checking: This planner method is introduced on `SnapshotScan` 
making it available for all the inheritors in the hierarchy. Is this really 
relevant for all of them or can we push this down to narrow the scope? Maybe 
`DataScan`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to