AP24110011695 commented on PR #4292: URL: https://github.com/apache/iceberg-python/pull/4292#issuecomment-6836608254
Follow-up verification on the two new commits (7b10913 + d334371): - The evaluator is now picked **per manifest** ( inside the manifest loop), matching the suggested shape — the per-entry content check and the two competing evaluators are gone. - The rename to `ignore_residuals` (default `False`) is complete — no stale `prune_delete_files` references remain in the diff. - Ran `tests/table/test_upsert.py`, `tests/table/test_delete_file_index.py` and `tests/table/test_evaluator_planning.py` on head `d334371` locally: 22 passed, and the 17 failures are the identical set that fails on pristine main in my environment (Windows/datafusion warnings baseline) — so no regressions from this PR, and the four new upsert tests all pass. The NaN-partition predicate addition (`IsNaN` for float partition values in upsert equality) also reads correctly alongside it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
