kevinjqliu commented on code in PR #4292:
URL: https://github.com/apache/iceberg-python/pull/4292#discussion_r4555648657
##########
pyiceberg/table/__init__.py:
##########
@@ -2863,12 +2876,20 @@ def __init__(
row_filter: str | BooleanExpression = ALWAYS_TRUE,
case_sensitive: bool = True,
options: Properties = EMPTY_DICT,
+ prune_delete_files: bool = True,
Review Comment:
nit: can we use something like
```python
_ignore_residuals=True,
```
instead? It follows the repo's conventions more closely:
- The `_` prefix keeps it out of the public API, like
`_isolation_operation`; `ManifestGroupPlanner` shipped in 0.12.0.
- It matches Java's
[`ignoreResiduals`](https://github.com/apache/iceberg/blob/805a2868ffaab46ca08620a186ace8d990eb8d52/core/src/main/java/org/apache/iceberg/DeleteFileIndex.java#L638):
the caller says files are read in full, and the planner keeps every delete
file and sets residuals to always true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]