gaborkaszab commented on code in PR #17523:
URL: https://github.com/apache/iceberg/pull/17523#discussion_r4555340971
##########
core/src/test/java/org/apache/iceberg/TestRowLineageMetadata.java:
##########
@@ -70,40 +70,108 @@ public void cleanup() {
public void testSnapshotRowIDValidation() {
Snapshot snapshot =
new BaseSnapshot(
- 0, 1, null, 0, DataOperations.APPEND, null, 1, "ml.avro", null,
null, null);
+ 0 /* sequenceNumber */,
+ 1 /* snapshotId */,
+ null /* parentId */,
+ 0 /* timestampMillis */,
+ DataOperations.APPEND,
+ null /* summary */,
+ 1 /* schemaId */,
+ "ml.avro" /* manifestListLocation */,
+ null /* rootManifest */,
+ null /* firstRowId */,
+ null /* addedRows */,
+ null /* keyId */);
Review Comment:
I checked, adding a null to parameters doesn't make the line too long to
indicate the reformatting. Not doing that would reduce much noise from the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]