nastra commented on code in PR #17523:
URL: https://github.com/apache/iceberg/pull/17523#discussion_r4547922641


##########
api/src/main/java/org/apache/iceberg/Snapshot.java:
##########
@@ -166,10 +166,26 @@ default Iterable<DeleteFile> removedDeleteFiles(FileIO 
io) {
   /**
    * Return the location of this snapshot's manifest list, or null if it is 
not separate.
    *
-   * @return the location of the manifest list for this Snapshot
+   * <p>Only set for tables with format version 1 through 3. Snapshots in v4 
tables use {@link
+   * #rootManifestLocation()} instead.
+   *
+   * @return the location of the manifest list for this snapshot
    */
   String manifestListLocation();
 
+  /**
+   * Return the location of this snapshot's root manifest, or null if this 
snapshot has no root
+   * manifest.
+   *
+   * <p>v4 snapshots store this in {@code root-manifest} instead of a manifest 
list. At most one of

Review Comment:
   "At most one of this..." reads a bit confusing. Maybe just say something 
like "Snapshots in v1-v3 use {@link #manifestListLocation()} instead"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to