Rishavbhattarai commented on PR #18813: URL: https://github.com/apache/iceberg/pull/18813#issuecomment-6784451990
Thanks @adiranjan25, a19dce4 looks right to me. All six comparisons and both set predicates in `ResidualEvaluator` now go through `PredicateComparisons`, and the tests cover both zero signs for float and double. Keeping the Parquet dictionary filter for a follow-up is fine with me. If you open that issue, tag me and I can help test it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
