adiranjan25 commented on PR #18813: URL: https://github.com/apache/iceberg/pull/18813#issuecomment-6759552593
Thanks @Rishavbhattarai for the detailed review. I've addressed the `ResidualEvaluator` signed-zero issue in commit `a19dce4f4`. The changes cover all six comparison predicates and both `IN`/`NOT IN` operations, using the existing `PredicateComparisons` helper. I've also added regression tests for Float and Double, covering both signed-zero directions across all eight predicates. Local Spotless formatting and targeted `TestResiduals` tests passed. GitHub CI is currently running. I'll keep the Parquet dictionary-filter concern as a separate follow-up to maintain a focused scope for this PR. Thanks again for your feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
