AynSiddiqui commented on code in PR #2456: URL: https://github.com/apache/iceberg-go/pull/2456#discussion_r4503135381
########## CONTRIBUTING.md: ########## @@ -62,9 +62,20 @@ Integration tests require Docker and are gated behind a build tag: ```bash docker compose -f internal/recipe/docker-compose.yml up -d rest object-store create-bucket --wait +eval "$(make integration-env)" go test -tags integration ./... ``` +`make integration-env` prints the environment the tests need, including `AWS_S3_ENDPOINT` (the local object store) and `AWS_REGION`, so run it after the containers are up. Without `AWS_S3_ENDPOINT`, the S3-backed tests send requests to real AWS S3 and fail (for example with a `301 PermanentRedirect`). + +Some integration tests need services that this command does not start (Hive, Azure, GCS and Spark). To run the suites CI runs, start everything and use the make target instead: + +```bash +make integration-setup +eval "$(make integration-env)" +make integration-test +``` Review Comment: Agreed. I removed the duplicate and replaced it with one line that links to the README's [Integration tests](https://github.com/apache/iceberg-go#integration-tests) section for the full CI suite (Hive, Azure, GCS, Spark). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
