AynSiddiqui commented on code in PR #2456: URL: https://github.com/apache/iceberg-go/pull/2456#discussion_r4503131781
########## CONTRIBUTING.md: ########## @@ -62,9 +62,20 @@ Integration tests require Docker and are gated behind a build tag: ```bash docker compose -f internal/recipe/docker-compose.yml up -d rest object-store create-bucket --wait +eval "$(make integration-env)" go test -tags integration ./... Review Comment: Done. The command now runs only the packages this stack serves: `go test -tags integration ./catalog/rest/... ./catalog/sql/... ./table/maintenance/... ./io/gocloud/s3/...` I ran it locally against `rest` + `object-store` and all packages pass. The scan-planning and Polaris tests in `catalog/rest` skip here because they're gated on `RUN_INTEGRATION_TESTS` and `REST_CATALOG_URI`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
