nastra commented on code in PR #18378:
URL: https://github.com/apache/iceberg/pull/18378#discussion_r4477754375
##########
core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java:
##########
@@ -44,18 +43,16 @@ public class AuthSessionCache implements AutoCloseable {
private volatile Cache<String, AuthSession> sessionCache;
/**
- * Creates a new cache with the given session timeout, and with default
executor and default
- * ticker for eviction tasks.
+ * Creates a new cache with the given session timeout, and with Caffeine's
default executor and
+ * the default ticker for eviction tasks.
*
- * @param name a distinctive name for the cache.
+ * @param name a distinctive name for the cache. Retained for API
compatibility; no dedicated
+ * thread pool is created, so eviction tasks run on Caffeine's default
executor.
Review Comment:
```suggestion
* @param name a distinctive name for the cache.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
