nastra commented on code in PR #18378:
URL: https://github.com/apache/iceberg/pull/18378#discussion_r4477738483
##########
core/src/main/java/org/apache/iceberg/rest/auth/AuthSessionCache.java:
##########
@@ -64,8 +61,8 @@ public AuthSessionCache(String name, Duration sessionTimeout)
{
*
* @param sessionTimeout the session timeout. Sessions will become eligible
for eviction after
* this duration of inactivity.
- * @param executor the executor to use for eviction tasks; if null, the
cache will create a
- * default executor. The executor will be closed when this cache is
closed.
+ * @param executor the executor to use for eviction tasks; if null,
Caffeine's default executor is
+ * used. An {@link ExecutorService} executor is shut down when this
cache is closed.
Review Comment:
```suggestion
* used. The executor will be closed when this cache is closed.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
