dragonknightk commented on PR #3573: URL: https://github.com/apache/iceberg-rust/pull/3573#issuecomment-6647108050
@laskoviymishka Great catches, thanks! I went through each of them: 1. The original comment wasn't clear. It didn't say the wrapped value isn't order-preserving, so readers might think wrapping has no side effects. 2. The comment made it look like decimal also follows Java, but Java doesn't wrap there at all. 3, 4 and 5 make the tests stricter, especially 5: before, it only caught a panic and would miss a wrong value. All addressed as you suggested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
