dragonknightk commented on PR #3573: URL: https://github.com/apache/iceberg-rust/pull/3573#issuecomment-6604854586
Thanks @mbutrovich, that's a really clear write-up of the spec side, and you're right that the `i32` case is where Java and the spec part ways. All points are addressed in the new commit: the three helpers now use `v.wrapping_sub(v.rem_euclid(width))` with your comments, the int test is renamed to `test_truncate_int_large_width` with spec-based expected values, and I added the projection case with `TestProjectionFixture`. I've updated the title and description too. Thanks again for the careful review (๑•̀ㅂ•́)و✧ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
