rdblue commented on code in PR #18526:
URL: https://github.com/apache/iceberg/pull/18526#discussion_r4461760751
##########
format/spec.md:
##########
@@ -522,15 +522,17 @@ The set of metadata columns is:
| **`2147483541 _commit_snapshot_id`** | `long` | The
snapshot ID in which the change occurred
|
| **`2147483540 _row_id`** | `long` | A unique
long assigned for row lineage, see [Row Lineage](#row-lineage)
|
| **`2147483539 _last_updated_sequence_number`** | `long` | The
sequence number which last updated this row, see [Row Lineage](#row-lineage)
|
+| **`2147483538 _last_updated_time`** | `timestamptz` | The
timestamp of the snapshot which last updated this row (v4 and later), see [Row
Lineage](#row-lineage) |
Review Comment:
I think that `timestamptz` makes more sense than `timestamp`. Timestamp with
time zone represents a point in time that will be shown to users in the SQL
session time zone. If we were to use timestamp without time zone, the only
difference would be that the time would be shown to all users the same way. In
either case, the value is stored as some offset from the unix epoch. I think
showing the value in the session time zone is what users expect so we should
use `timestamptz`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
