zhjwpku commented on code in PR #18526: URL: https://github.com/apache/iceberg/pull/18526#discussion_r4429895603
########## format/spec.md: ########## @@ -1053,7 +1059,7 @@ A simple (and recommended) way for writers to adapt existing metadata for table #### Inheritance -Values for `snapshot_id`, `sequence_number`, and `file_sequence_number` are inherited from manifest metadata when `null`. That is, if the field is `null` for an entry, then the entry must inherit its value from the manifest file's metadata, stored in the snapshot root file. +Values for `snapshot_id`, `sequence_number`, and `file_sequence_number` are inherited from manifest metadata when `null`. That is, if the field is `null` for an entry, then the entry must inherit its value from the manifest file's metadata, stored in the snapshot root file. In v4, `snapshot_timestamp` is also inherited when `null`; see [Snapshot Timestamp Inheritance](#snapshot-timestamp-inheritance). Review Comment: I noticed that in other places it's `In v4 and later` but here it's just `In v4`, would be better to keep it consistent, but not a blocking one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
