vivek-9941 commented on PR #18361: URL: https://github.com/apache/iceberg/pull/18361#issuecomment-6598274012
Thanks for the excellent feedback! I've addressed both issues in commit a65c3fd54: 1. Fixed equalityDeleteBeforePromotionAppliedToDataAfter test logic: ✅ Reversed the commit order: data file first, then equality delete ✅ Now the equality delete has a higher sequence number and correctly applies to the pre-promotion data file ✅ Test validates partition matching after promotion with assertThat(tasks.get(0).deletes()).hasSize(1) ✅ Removed the inaccurate comment about DeleteFileIndex 2. Strengthened assertions in positionDeleteBeforePromotionCommitsWithRowDelta and bothDataAndDeleteFilesBeforePromotion: ✅ Replaced sum >= 1 with per-file assertions using file path matching ✅ Pre-promotion file (data.parquet or data-both.parquet): assertThat(prePromotionTask.deletes()).hasSize(1) ✅ Post-promotion file (/data-after*.parquet): assertThat(postPromotionTask.deletes()).isEmpty() ✅ Now ensures deletes are attached to the correct target files The tests now properly validate that: Deletes continue to apply after partition type promotion Partition matching works correctly for both Integer(5) and Long(5L) values Deletes attach to the correct files (pre-promotion) and not to wrong files (post-promotion) The lazy iterator is consumed and actual partition matching logic executes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
