vivek-9941 commented on PR #18361: URL: https://github.com/apache/iceberg/pull/18361#issuecomment-6576437931
Thanks for the detailed feedback on cf33b01a9! I've addressed both issues: 1. Test validation fixed (commits 401a3ded7 + 827e8d11d): ✅ Removed assertThatCode(...).doesNotThrowAnyException() from all 4 delete file tests ✅ Replaced with direct commit calls that allow exceptions to propagate naturally ✅ Tests now properly consume the planFiles() iterator and validate delete file application ✅ All tests filter on region = 5L and assert on task count and task.deletes().size() as requested ✅ Corrected positionDeleteBeforePromotionCommitsWithRowDelta to expect 2 tasks (it adds 2 data files: one before promotion, one after) 2. CVE cleanup: ✅ CVE-2026-68494 was already removed in commit d1f03807d (not present in trivyignore file) The tests now correctly validate that deletes continue to apply after partition type promotion by consuming the lazy iterator and checking the actual task properties. All CI checks are passing. Ready for review! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
