Sruhvx-jpg commented on PR #3288:
URL: https://github.com/apache/iceberg-rust/pull/3288#issuecomment-6541091588
We originally had .contains("failed to load signing credential"), but
@laskoviymishka flagged that matching internal error strings is fragile:
> Asserting on the \"failed to load signing credential\" substring couples
this to a reqsign-internal message that'll drift on upgrades. I'd assert on the
error kind() instead
And on asserting specific error kinds:
> Unexpected is OpenDAL's current mapping, not a FileIO contract [...] I'd
assert just is_err() here (same for the double-close at :536 and the credential
case in credential_suite.rs:126), and if we want a specific kind, spec it in
the trait docs first.
Also, yes, am making the backends/ module refactor as you suggested!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
